saurabhd336 commented on code in PR #9058:
URL: https://github.com/apache/pinot/pull/9058#discussion_r923134910
##########
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotTaskRestletResource.java:
##########
@@ -231,6 +236,23 @@ public Map<String,
PinotHelixTaskResourceManager.TaskDebugInfo> getTasksDebugInf
return _pinotHelixTaskResourceManager.getTasksDebugInfoByTable(taskType,
tableNameWithType, verbosity);
}
+ @GET
+ @Path("/tasks/generator/{tableNameWithType}/{taskType}/debug")
+ @ApiOperation("Fetch task generation information for the recent runs of the
given task for the given table")
+ public BaseTaskGeneratorInfo getTaskGenerationDebugInto(
+ @ApiParam(value = "Task type", required = true) @PathParam("taskType")
String taskType,
+ @ApiParam(value = "Table name with type", required = true)
@PathParam("tableNameWithType")
+ String tableNameWithType) {
+ BaseTaskGeneratorInfo
+ taskGeneratorMostRecentRunInfo =
_taskManagerStatusCache.fetchTaskGeneratorInfo(tableNameWithType, taskType);
Review Comment:
Ack. The status can indeed be stored across different controllers. I was
trying the following two approaches
Upon hitting this API,
1) The controller makes a HTTP call to every other controller to get their
respective in-memory debug statuses, waits for the responses and finally
responds back with a list of all the responses.
2) Use the helix messaging framework to broadcast a message to each
controller, and via the `AsyncCallback`, collate all the replies and respond
back (https://github.com/saurabhd336/pinot/pull/9/files)
I'll test and evaluate both approaches and update this PR accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
