ddcprg commented on code in PR #9051: URL: https://github.com/apache/pinot/pull/9051#discussion_r922543334
########## pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/kafka/schemaregistry/SchemaRegistryStarter.java: ########## @@ -0,0 +1,106 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.integration.tests.kafka.schemaregistry; + +import java.util.HashMap; +import java.util.Map; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; +import org.testcontainers.containers.GenericContainer; +import org.testcontainers.containers.KafkaContainer; +import org.testcontainers.containers.Network; +import org.testcontainers.containers.wait.strategy.Wait; +import org.testcontainers.utility.DockerImageName; + + +public class SchemaRegistryStarter { Review Comment: I couldn't find a better place for this class ########## pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/kafka/schemaregistry/SchemaRegistryStarter.java: ########## @@ -0,0 +1,106 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.integration.tests.kafka.schemaregistry; + +import java.util.HashMap; +import java.util.Map; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; +import org.testcontainers.containers.GenericContainer; +import org.testcontainers.containers.KafkaContainer; +import org.testcontainers.containers.Network; +import org.testcontainers.containers.wait.strategy.Wait; +import org.testcontainers.utility.DockerImageName; + + +public class SchemaRegistryStarter { + public static final int DEFAULT_PORT = 8081; + private static final String CONFLUENT_PLATFORM_VERSION = "7.2.0"; + private static final DockerImageName KAFKA_DOCKER_IMAGE_NAME = + DockerImageName.parse("confluentinc/cp-kafka:" + CONFLUENT_PLATFORM_VERSION); + private static final DockerImageName SCHEMA_REGISTRY_DOCKER_IMAGE_NAME = + DockerImageName.parse("confluentinc/cp-schema-registry:" + CONFLUENT_PLATFORM_VERSION); + private static final Logger LOGGER = LoggerFactory.getLogger(SchemaRegistryStarter.class); + + private SchemaRegistryStarter() { + } + + public static KafkaSchemaRegistryInstance startLocalInstance(int port) { + KafkaSchemaRegistryInstance kafkaSchemaRegistry = new KafkaSchemaRegistryInstance(port); + kafkaSchemaRegistry.start(); + return kafkaSchemaRegistry; + } + + public static class KafkaSchemaRegistryInstance { + private final int _port; + public KafkaContainer _kafkaContainer; + private Network _network; + private GenericContainer _schemaRegistryContainer; + + private KafkaSchemaRegistryInstance(int port) { + _port = port; + } + + public String getUrl() { + return "http://"; + _schemaRegistryContainer.getHost() + ":" + _schemaRegistryContainer.getMappedPort(_port); + } + + public void start() { + LOGGER.info("Starting schema registry"); + if (_kafkaContainer != null || _schemaRegistryContainer != null) { + throw new IllegalStateException("Schema registry is already running"); + } + + _network = Network.newNetwork(); + + _kafkaContainer = new KafkaContainer(KAFKA_DOCKER_IMAGE_NAME).withNetwork(_network).withNetworkAliases("kafka") Review Comment: I'm using testcontainers because I had loads of dependency issues flagged by enforcer and I didn't find an easy way to fix them, otherwise schema registry could've been embedded in the code instead of using a container. Also, this spins up it own Kafka broker because I wasn't able to connect the container to the Kafka broker that the test spins up - there is hostname translation and I couldn't get Kafka listeners to play nicely with that -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
