siddharthteotia commented on code in PR #8989:
URL: https://github.com/apache/pinot/pull/8989#discussion_r919527719
##########
pinot-spi/src/main/java/org/apache/pinot/spi/config/table/TableConfig.java:
##########
@@ -101,6 +102,9 @@ public class TableConfig extends BaseJsonConfig {
@JsonPropertyDescription(value = "Configs for Table config tuner")
private List<TunerConfig> _tunerConfigList;
+ @JsonPropertyDescription(value = "Name of the table-group")
+ private String _tableGroupName;
Review Comment:
Did we consider referring to TableGroupConfig directly here ? If null, then
current behavior. If non null, then table is part of some TableGroup. See the
example of `FieldConfig` which by itself is like a sub-config but is referred
to from TableConfig.
##########
pinot-spi/src/main/java/org/apache/pinot/spi/config/table/TableConfig.java:
##########
@@ -101,6 +102,9 @@ public class TableConfig extends BaseJsonConfig {
@JsonPropertyDescription(value = "Configs for Table config tuner")
private List<TunerConfig> _tunerConfigList;
+ @JsonPropertyDescription(value = "Name of the table-group")
+ private String _tableGroupName;
Review Comment:
Did we consider referring to `TableGroupConfig` directly here ? If null,
then current behavior. If non null, then table is part of some TableGroup. See
the example of `FieldConfig` which by itself is like a sub-config but is
referred to from TableConfig.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
