snleee commented on code in PR #9006:
URL: https://github.com/apache/pinot/pull/9006#discussion_r919183805
##########
pinot-spi/src/main/java/org/apache/pinot/spi/utils/builder/ControllerRequestURLBuilder.java:
##########
@@ -344,6 +344,10 @@ public String forSegmentMetadata(String tableName, String
segmentName) {
return StringUtil.join("/", _baseUrl, "segments", tableName,
encode(segmentName), "metadata");
}
+ public String forSegmentLineage(String tableName, String tableType) {
Review Comment:
`forListAllSegmentLineages` would be better naming (following the convention
with other functions)
##########
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotSegmentUploadDownloadRestletResource.java:
##########
@@ -652,6 +652,29 @@ public Response endReplaceSegments(
}
}
+ @GET
+ @Path("segments/{tableName}/listSegmentLineage")
+ @Authenticate(AccessType.READ)
+ @Produces(MediaType.APPLICATION_JSON)
+ @ApiOperation(value = "List segment lineage", notes = "List segment lineage")
+ public Response listSegmentLineage(
Review Comment:
I think that @yuanbenson probably put the new API to
`PinotSegmentUploadDownloadRestletResource` because the segment lineage-related
code is being written in the segment replacement-related APIs.
Another way to put this is `e.g. GET /tables/{tableName}/segments/lineage`
under `PinotSegmentRestletResource` as @walterddr suggested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
