somandal commented on code in PR #9004:
URL: https://github.com/apache/pinot/pull/9004#discussion_r918401761
##########
pinot-core/src/main/java/org/apache/pinot/core/common/evaluators/DefaultJsonPathEvaluator.java:
##########
@@ -90,7 +90,7 @@ public <T extends ForwardIndexReaderContext> void
evaluateBlock(int[] docIds, in
}
}
} else {
- switch (reader.getValueType()) {
+ switch (reader.getStoredType()) {
Review Comment:
@Jackie-Jiang I commented out the `JSON` branch under the switch and ran all
the tests under `pinot-core`. No test failures. Checked that
`JsonExtractScalarTest`, `JsonMatchQueriesTest` and
`JsonIngestionFromAvroQueriesTest` run fine. Is there any additional testing I
can do to validate that this `JSON` path is indeed never run?
Should I remove the `JSON` branch under these switch statements as part of
this change?
cc @siddharthteotia
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
