[GitHub] [pinot] nizarhejazi commented on a diff in pull request #8927: Proper null handling in SELECT, ORDER BY, DISTINCT, and GROUP BY

[GitBox]

nizarhejazi commented on code in PR #8927:
URL: https://github.com/apache/pinot/pull/8927#discussion_r917457959


##########
pinot-core/src/main/java/org/apache/pinot/core/operator/docvalsets/ProjectionBlockValSet.java:
##########
@@ -50,6 +53,26 @@ public ProjectionBlockValSet(DataBlockCache dataBlockCache, 
String column, DataS
     _dataBlockCache = dataBlockCache;
     _column = column;
     _dataSource = dataSource;
+    NullValueVectorReader nullValueReader = _dataSource == null ? null : 
_dataSource.getNullValueVector();

Review Comment:
   Updated to do computation lazily, and removed null check.
   
   Please note that passing whether query has null handling enabled is tedious 
(need to pass QueryContext through many classes). Let me know if you still 
prefer to pass it through.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org