ankitsultana commented on code in PR #8989:
URL: https://github.com/apache/pinot/pull/8989#discussion_r909451432
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/assignment/instance/InstanceAssignmentDriver.java:
##########
@@ -55,19 +58,36 @@ public InstanceAssignmentDriver(TableConfig tableConfig) {
public InstancePartitions assignInstances(InstancePartitionsType
instancePartitionsType,
List<InstanceConfig> instanceConfigs, @Nullable InstancePartitions
existingInstancePartitions) {
String tableNameWithType = _tableConfig.getTableName();
- LOGGER.info("Starting {} instance assignment for table: {}",
instancePartitionsType, tableNameWithType);
+ Preconditions.checkState(!TableConfigUtils.isTableInGroup(_tableConfig));
Review Comment:
Are there any concerns with making ZK propertyStore a member of
`InstanceAssignmentDriver`? That would allow to get rid of this Precondition
here and return the pre-computed instance-partitions by doing a look-up on the
propertyStore here.
Otherwise we will have to do a check whenever we call this method to see if
the table is part of a table-group and handle that case every time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
