jasperjiaguo commented on code in PR #8965:
URL: https://github.com/apache/pinot/pull/8965#discussion_r909223300
##########
pinot-controller/src/main/java/org/apache/pinot/controller/recommender/io/InputManager.java:
##########
@@ -203,13 +204,15 @@ private void reorderDimsAndBuildMap()
String sortedColumn =
_overWrittenConfigs.getIndexConfig().getSortedColumn();
Set<String> invertedIndexColumns =
_overWrittenConfigs.getIndexConfig().getInvertedIndexColumns();
Set<String> rangeIndexColumns =
_overWrittenConfigs.getIndexConfig().getRangeIndexColumns();
+ Set<String> jsonIndexColumns =
_overWrittenConfigs.getIndexConfig().getJsonIndexColumns();
Set<String> noDictionaryColumns =
_overWrittenConfigs.getIndexConfig().getNoDictionaryColumns();
/*Validate if there's conflict between NoDictionaryColumns and
dimNamesWithAnyIndex*/
Set<String> dimNamesWithAnyIndex = new HashSet<>();
dimNamesWithAnyIndex.add(sortedColumn);
dimNamesWithAnyIndex.addAll(invertedIndexColumns);
dimNamesWithAnyIndex.addAll(rangeIndexColumns);
+ dimNamesWithAnyIndex.addAll(jsonIndexColumns);
Review Comment:
This part is essentially to ensure
sortedColumn/invertedIndexColumns/rangeIndexColumns are dictionary encoded. On
the contrary, json index must be raw. L215 needs to be removed. Maybe we should
rename `dimNamesWithAnyIndex` to `dimNamesWithDictionaryDependentIndex`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
