somandal commented on code in PR #8917:
URL: https://github.com/apache/pinot/pull/8917#discussion_r904938926
##########
pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/index/reader/ForwardIndexReader.java:
##########
@@ -410,9 +411,318 @@ default byte[] getBytes(int docId, T context) {
/**
* MULTI-VALUE COLUMN RAW INDEX APIs
- * TODO: Not supported yet
*/
+ /**
+ * Fills the values
+ * @param docIds Array containing the document ids to read
+ * @param length Number of values to read
+ * @param maxNumValuesPerMVEntry maximum number of values per MV entry
+ * @param values Values to fill
+ * @param context Reader context
+ */
+ default void readValuesMV(int[] docIds, int length, int
maxNumValuesPerMVEntry, int[][] values, T context) {
+ switch (getStoredType()) {
+ case INT:
+ int[] intValueBuffer = new int[maxNumValuesPerMVEntry];
+ for (int i = 0; i < length; i++) {
+ int numValues = getIntMV(docIds[i], intValueBuffer, context);
Review Comment:
Got it. I've addressed this and your other comment as part of the new PR I
opened: https://github.com/apache/pinot/pull/8953
Let me know what you think! appreciate the feedback!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
