siddharthteotia commented on code in PR #8926:
URL: https://github.com/apache/pinot/pull/8926#discussion_r901952028
##########
pinot-core/src/main/java/org/apache/pinot/core/common/datablock/BaseDataBlock.java:
##########
@@ -211,7 +211,7 @@ public BaseDataBlock(ByteBuffer byteBuffer)
* @param rowId row ID
* @param colId column ID
*/
- protected abstract void positionCursorInFixSizedBuffer(int rowId, int colId);
+ protected abstract int computePositionCursorInFixSizedBuffer(int rowId, int
colId);
Review Comment:
(nit) update the jaavadoc to include the return value please ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
