mcvsubbu commented on PR #8828: URL: https://github.com/apache/pinot/pull/8828#issuecomment-1159089240
Please change the description. This PR does much more than just get reload status. Earlier design for reload was to "fire and forget" (send a reload helix message and let servers handle it as they please). This one (if I understand right) changes the reload command to start a helix task. have you considered what happens when controller is upgraded to the new version but the servers are running old version, and the reload command is issued? Please evaluate and add that to the PR description, and also mark this PR for release notes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
