mcvsubbu commented on code in PR #8907:
URL: https://github.com/apache/pinot/pull/8907#discussion_r899427901
##########
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java:
##########
@@ -682,7 +685,9 @@ private void logBrokerResponse(long requestId, String
query, RequestContext requ
brokerResponse.getOfflineThreadCpuTimeNs(),
brokerResponse.getOfflineSystemActivitiesCpuTimeNs(),
brokerResponse.getOfflineResponseSerializationCpuTimeNs(),
brokerResponse.getRealtimeTotalCpuTimeNs(),
brokerResponse.getRealtimeThreadCpuTimeNs(),
brokerResponse.getRealtimeSystemActivitiesCpuTimeNs(),
- brokerResponse.getRealtimeResponseSerializationCpuTimeNs(),
StringUtils.substring(query, 0, _queryLogLength));
+ brokerResponse.getRealtimeResponseSerializationCpuTimeNs(),
+ ((HttpRequesterIdentity)
requesterIdentity).getHttpHeaders().toString(),
Review Comment:
The idea of keeping the format as "key=value" and then a space and then the
query is so that we can write scripts for post-processing, while looking at
logs in production easily. If the value has spaces in it, that becomes a
problem. It will certainly break some of the scripts we use for debugging.
If we are adding anything like a generic string that may have spaces, I
suggest putting a marker AFTER the query, and adding the information there.
Also, we don't want to make the line too long.
Suggestions to add IP addresses (known not to have spaces in them) is good,
and if that suffices then we can always add it in the "key=value" section. But
please do name it correctly, instead of calling it "RequesterIdentity". This
class can mean different in different environments, so please don't add this in
the log message
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
