mcvsubbu commented on issue #8804: URL: https://github.com/apache/pinot/issues/8804#issuecomment-1157859558
My only problem with this approach is if someone out there wants to migrate from HLC to LLC and does not set replicasPerPartition. Here is my suggestion: We remove any note we have regarding migration from HLC to LLC, and document that the only way you can migrate is to spin up another LLC cluster and shut down the HLC cluster. We may need to make some suggestions for moving historical data. AFAIK only LinkedIn attempted an in-place migration. It is probably not feasible anymore, even at LinkedIn with the increased ingestion and query volumes. We can then remove all support for HLC+LLC, and then go with the approach you are suggesting. Also, I don't know of anyone using HLC, so it is safe to assume that any migration may only happen in a future new stream type that may not support LLC to start with (but may eventually do so). This will be a clean migration to deprecating `replicasPerPartition` in favor of `replication`. @yupeng9 can help check whether Uber is still using [this](https://github.com/apache/pinot/blob/master/pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotTableIdealStateBuilder.java#L89) code, but that is not important to remove. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
