Jackie-Jiang commented on PR #8818: URL: https://github.com/apache/pinot/pull/8818#issuecomment-1156850809
@gortiz @atris Thanks for taking time looking into this issue. Even though we might not move forward with the query rewrite, we got several valuable insights from the benchmark. With regard to the query syntax, +100 on we should keep the query behavior consistent with or without the FST index. Currently we try to convert java regex to Lucene search query using `RegexpPatternConverterUtils.regexpLikeToLuceneRegExp()`. The support is very limited though, and might only be able to cover the basic `LIKE` predicate. We want to utilize the FST to accelerate the regex matching (`LIKE` and `REGEXP_LIKE`). There are 2 approaches: - Add a new predicate type, e.g. `FST_LIKE` and take the Lucene dialect - Make FST work on java regex I personally prefer the second approach because it can improve the existing query performance, but it requires changes to the native FST, and we cannot support Lucene FST anymore. Or we can support both, and make the `FST_LIKE` only work with Lucene FST. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
