npawar commented on code in PR #8823: URL: https://github.com/apache/pinot/pull/8823#discussion_r897445846
########## pinot-controller/src/main/java/org/apache/pinot/controller/api/upload/ZKOperator.java: ########## @@ -60,8 +62,9 @@ public ZKOperator(PinotHelixResourceManager pinotHelixResourceManager, Controlle } public void completeSegmentOperations(String tableNameWithType, SegmentMetadata segmentMetadata, - @Nullable URI finalSegmentLocationURI, File segmentFile, String downloadUrl, @Nullable String crypterName, - long segmentSizeInBytes, boolean enableParallelPushProtection, boolean allowRefresh, HttpHeaders headers) + FileUploadType uploadType, @Nullable URI finalSegmentLocationURI, File segmentFile, String sourceDownloadURIStr, Review Comment: Addressed all other comments. For this one, I kinda prefer keeping the uploadType, so it is very clear when reading. Don't want to rely on `sourceDownloadURIStr` as it can be non-null even in URI push case, but we want to use segment file in that case. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
