Jackie-Jiang commented on code in PR #8779:
URL: https://github.com/apache/pinot/pull/8779#discussion_r887239953
##########
pinot-spi/src/main/java/org/apache/pinot/spi/data/DateTimeFormatPatternSpec.java:
##########
@@ -65,6 +65,20 @@ public DateTimeFormatPatternSpec(String timeFormat,
@Nullable String sdfPatternW
}
}
+ public DateTimeFormatPatternSpec(DateTimeFieldSpec.TimeFormat timeFormat,
String timeFormatStyle,
Review Comment:
(minor)
```suggestion
public DateTimeFormatPatternSpec(DateTimeFieldSpec.TimeFormat timeFormat,
@Nullable String sdfPattern,
```
##########
pinot-spi/src/main/java/org/apache/pinot/spi/data/DateTimeFormatSpec.java:
##########
@@ -84,6 +127,23 @@ public DateTimeFormatSpec(int columnSize, String
columnUnit, String columnTimeFo
_patternSpec = new DateTimeFormatPatternSpec(columnTimeFormat);
}
+ /**
+ * Constructs a dateTimeSpec format, given the components of a format
+ */
+ public DateTimeFormatSpec(String columnTimeFormat, String columnUnit, int
columnSize) {
Review Comment:
Yes, I'd suggest removing the new added constructor and the tests using it.
We can clean up the old ones separately
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
