saurabhd336 commented on code in PR #8708:
URL: https://github.com/apache/pinot/pull/8708#discussion_r884539829
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/TableConfigUtils.java:
##########
@@ -505,34 +505,40 @@ static void validateTaskConfigs(TableConfig tableConfig,
Schema schema) {
* - comparison column exists
*/
@VisibleForTesting
- static void validateUpsertConfig(TableConfig tableConfig, Schema schema) {
- if (tableConfig.getUpsertMode() == UpsertConfig.Mode.NONE) {
+ static void validateUpsertAndDedupConfig(TableConfig tableConfig, Schema
schema) {
+ if (tableConfig.getUpsertMode() == UpsertConfig.Mode.NONE &&
tableConfig.getDedupConfig() == null) {
Review Comment:
Idea here is, if the config json doesn't have dedupeConfig field, no need to
run the validaiton
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
