saurabhd336 commented on code in PR #8663:
URL: https://github.com/apache/pinot/pull/8663#discussion_r879059202
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/periodictask/ControllerPeriodicTask.java:
##########
@@ -103,10 +105,16 @@ public final ControllerMetrics getControllerMetrics() {
* <p>
* Override one of this method, {@link #processTable(String)} or {@link
#processTable(String, C)}.
*/
- protected void processTables(List<String> tableNamesWithType) {
+ protected void processTables(List<String> tableNamesWithType, String
taskParamsJson) {
int numTables = tableNamesWithType.size();
LOGGER.info("Processing {} tables in task: {}", numTables, _taskName);
- C context = preprocess();
+ C context;
+ try {
+ context = preprocess(taskParamsJson);
+ } catch (IOException e) {
Review Comment:
Moving to Properties instead of json makes `preprocess` not throw
exceptions. Ack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
