Airliquide76 commented on code in PR #8589:
URL: https://github.com/apache/pinot/pull/8589#discussion_r877967143
##########
pinot-core/src/main/java/org/apache/pinot/core/common/MinionConstants.java:
##########
@@ -67,6 +67,7 @@ public static class ConvertToRawIndexTask {
// Purges rows inside segment that match chosen criteria
public static class PurgeTask {
public static final String TASK_TYPE = "PurgeTask";
+ public static final String DELTA_TIME_PERIOD_KEY = "deltaPurgeTimePeriod";
Review Comment:
Integration test added. Was hard to manipulate segmentMetadata in the setUp.
I also was forced to implement a purge (does not purge return false every row
and a BIG TODO in the baseMinionStarter ) to run the tests.
Open to review again @Jackie-Jiang many thx for you time
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
