Jackie-Jiang commented on code in PR #8724: URL: https://github.com/apache/pinot/pull/8724#discussion_r877546789
########## pinot-common/src/main/java/org/apache/pinot/segment/local/customobject/DoubleVector.java: ########## @@ -0,0 +1,106 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.segment.local.customobject; Review Comment: I'd suggest also using `DoubleArrayList` for the intermediate result, and add some helper functions in the aggregation function implementation (or a separate util class if you think these are common operations and can be shared across other functions added in the future) to do vector add etc on top of the `DoubleArrayList`. Both of these 2 classes are just Comparable wrapper on top of the double array. We probably don't want to maintain 2 separate custom objects for the same functionality. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
