saurabhd336 commented on code in PR #8663:
URL: https://github.com/apache/pinot/pull/8663#discussion_r876631007
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java:
##########
@@ -1061,6 +1068,9 @@ IdealState ensureAllPartitionsConsuming(TableConfig
tableConfig, PartitionLevelS
// b. update current segment in idealstate to ONLINE (only if partition
is present in newPartitionGroupMetadata)
// c. add new segment in idealstate to CONSUMING on the hosts (only if
partition is present in
// newPartitionGroupMetadata)
+ // 2. The latest metadata is in DONE state, but the idealstate has no
segment in CONSUMING state.
+ // a. Create metadata for new IN_PROGRESS segment with startOffset set
to latest segments' end offset.
+ // b. Add the newly created segment to idealstate with segment state
set to CONSUMING.
// 2. The latest metadata is IN_PROGRESS, but segment is not there in
idealstate.
Review Comment:
Ack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
