xiangfu0 commented on PR #8705: URL: https://github.com/apache/pinot/pull/8705#issuecomment-1128227700
> LGTM. > > To prevent regression, we can probably add a new test into the `OfflineClusterIntegrationTest` which is similar to the triggering test for other index types. We have a method `restartServers()` to restart all servers in the integration test Nice, then we should just have a generic framework to test the below behaviors by providing the old/ new table configs: ``` 1. Add index, reload all segments -> check index are created 2. Remove index, reload all segments -> check index are removed 3. Add index, restart servers -> check index are created 4. Remove index restart servers -> check index are removed ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
