Jackie-Jiang commented on code in PR #8713:
URL: https://github.com/apache/pinot/pull/8713#discussion_r874224167
##########
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java:
##########
@@ -762,23 +763,31 @@ private void handleSubquery(Expression expression, long
requestId, JsonNode json
/**
* Resolves the actual table name for:
* - Case-insensitive cluster
- * - Table name in the format of [database_name].[table_name]
+ * - Table name in the format of [database_name].[namespace].[table_name]
Review Comment:
I don't think this change is required. The `[namespace].[table_name]` is the
table name, and within pinot there is no concept of `namespace`
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/TableConfigUtils.java:
##########
@@ -144,10 +145,16 @@ private static Set<ValidationType>
parseTypesToSkipString(@Nullable String types
* <li>Table name shouldn't contain dot or space in it</li>
* </ul>
*/
- public static void validateTableName(TableConfig tableConfig) {
+ public static void validateTableName(TableConfig tableConfig,
PinotConfiguration pinotConfiguration) {
Review Comment:
Suggest passing a boolean `allowDot` instead of the whole config
##########
pinot-spi/src/main/java/org/apache/pinot/spi/utils/CommonConstants.java:
##########
@@ -172,6 +172,8 @@ public static class Instance {
public static final String CONFIG_OF_PINOT_BROKER_STARTABLE_CLASS =
"pinot.broker.startable.class";
public static final String CONFIG_OF_PINOT_SERVER_STARTABLE_CLASS =
"pinot.server.startable.class";
public static final String CONFIG_OF_PINOT_MINION_STARTABLE_CLASS =
"pinot.minion.startable.class";
+ public static final String CONFIG_OF_ALLOW_TABLE_NAME_DOTS =
"pinot.table.name.dots.enabled";
Review Comment:
Let's add it under `Helix` similar to `ENABLE_CASE_INSENSITIVE`. Suggest
naming it `allow.table.name.dots`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
