ddcprg commented on PR #8625: URL: https://github.com/apache/pinot/pull/8625#issuecomment-1125751705
> > I would look like these still need adding to the format() method that Jackie has mentioned above however there is a convertAndFormat() that seems to be doing the correct thing > > Oh I see. in this case can you adjust the PR and resolve the conflicts? I can take another look afterwards, thank you so much! hey @walterddr sorry I didn't read your message. Thanks for that, I've resolved the conflicts and pushed a change but feel free to take over. Let me know if you prefer me to close the PR so you can push a fresh commit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
