walterddr commented on code in PR #8689:
URL: https://github.com/apache/pinot/pull/8689#discussion_r871798483
##########
pinot-query-planner/src/main/java/org/apache/pinot/query/planner/stage/TableScanNode.java:
##########
@@ -19,23 +19,25 @@
package org.apache.pinot.query.planner.stage;
import java.util.List;
-import org.apache.calcite.rel.type.RelDataType;
import org.apache.pinot.query.planner.serde.ProtoProperties;
+import org.apache.pinot.spi.data.FieldSpec;
public class TableScanNode extends AbstractStageNode {
@ProtoProperties
private String _tableName;
@ProtoProperties
private List<String> _tableScanColumns;
+ @ProtoProperties
+ private FieldSpec.DataType _rowType;
public TableScanNode(int stageId) {
super(stageId);
}
- public TableScanNode(int stageId, RelDataType rowType, String tableName,
List<String> tableScanColumns) {
+ public TableScanNode(int stageId, FieldSpec.DataType rowType, String
tableName, List<String> tableScanColumns) {
Review Comment:
2nd thought. no need to encode this here. we will add RexExpression if needed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
