Jackie-Jiang commented on PR #8645: URL: https://github.com/apache/pinot/pull/8645#issuecomment-1119108429
Going over #8639, there are some race condition not handled. Segment deletion is an async operation, so if there are common dest segments, the segment deletion can actually delete the segment just pushed by the new task. To fix that, we can remove the common dest segments from the original entry and then mark it as REVERTED. The common dest segments should not be added to the clean up list. With that, we don't need the extra logic in this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
