[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #8640: allow to take data outside the time window by negating the window filter

[GitBox]

Jackie-Jiang commented on code in PR #8640:
URL: https://github.com/apache/pinot/pull/8640#discussion_r865474512


##########
pinot-core/src/main/java/org/apache/pinot/core/segment/processing/timehandler/TimeHandlerConfig.java:
##########
@@ -57,6 +59,10 @@ public long getEndTimeMs() {
     return _endTimeMs;
   }
 
+  public boolean getNegateWindowFilter() {

Review Comment:
   (minor)
   ```suggestion
     public boolean isNegateWindowFilter() {
   ```



##########
pinot-core/src/main/java/org/apache/pinot/core/segment/processing/timehandler/TimeHandlerConfig.java:
##########
@@ -27,6 +27,7 @@ public class TimeHandlerConfig {
   // Time values not within the time range [_startTimeMs, _endTimeMs) are 
filtered out

Review Comment:
   (minor) Update the comments here



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org