yupeng9 commented on PR #8620: URL: https://github.com/apache/pinot/pull/8620#issuecomment-1118020075
> > > > current implementation of `ST_Contains` is for Geometry only https://github.com/apache/pinot/blob/master/pinot-core/src/main/java/org/apache/pinot/core/geospatial/transform/function/StContainsFunction.java > > > > > > > > > @yupeng9 Understood, but why does it not apply to the geography objects? > > > > > > Different implementation, and I didn't scope it in the inital impl > > @yupeng9 Is H3 index always based on the geography objects? If so, we cannot use H3 index for ST_Contains because that will give wrong result (mixing geometry calculation with geography calculation). Another option is to allow using geometry contains on geography objects because they should give close estimation on small areas. It won't work for large areas though. Yes, H3 is always based on geography. And yes, we can do approximation for small area. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
