xiangfu0 commented on code in PR #8633:
URL: https://github.com/apache/pinot/pull/8633#discussion_r864378489
##########
pinot-spi/src/main/java/org/apache/pinot/spi/config/table/TimestampIndexGranularity.java:
##########
@@ -104,6 +104,6 @@ public static FieldSpec
getFieldSpecForTimestampColumnWithGranularity(FieldSpec
* @return Time conversion expression
*/
public static String getTransformExpression(String timeColumn,
TimestampIndexGranularity granularity) {
- return "dateTrunc(\'" + granularity + "\', " + timeColumn + ")";
+ return String.format("dateTrunc('%s', %s)", granularity, timeColumn);
Review Comment:
I remember @richardstartin mentioned that string plus is faster than
string.format.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
