saurabhd336 commented on code in PR #8582:
URL: https://github.com/apache/pinot/pull/8582#discussion_r860636714
##########
pinot-segment-local/src/test/java/org/apache/pinot/segment/local/recordtransformer/RecordTransformerTest.java:
##########
@@ -178,6 +178,27 @@ public void testSanitationTransformer() {
}
}
+ @Test
+ public void testLogicalScalarOps() {
+ TableConfig tableConfig = new
TableConfigBuilder(TableType.OFFLINE).setTableName("testTable").build();
+
+ // expression true, filtered
+ GenericRow genericRow = getRecord();
+ tableConfig.setIngestionConfig(
+ new IngestionConfig(null, null, new FilterConfig("and(eq(svInt, 123),
lte(svInt, 123))"), null, null));
Review Comment:
Is was LTE. Hence it worked :)
Had added these to be able to test and / or. Made the tests a bit more
extensive.
All the filters actually match the record. SKIP_RECORD_KEY is being checked
for.
##########
pinot-segment-local/src/test/java/org/apache/pinot/segment/local/recordtransformer/RecordTransformerTest.java:
##########
@@ -178,6 +178,27 @@ public void testSanitationTransformer() {
}
}
+ @Test
+ public void testLogicalScalarOps() {
+ TableConfig tableConfig = new
TableConfigBuilder(TableType.OFFLINE).setTableName("testTable").build();
+
+ // expression true, filtered
+ GenericRow genericRow = getRecord();
+ tableConfig.setIngestionConfig(
+ new IngestionConfig(null, null, new FilterConfig("and(eq(svInt, 123),
lte(svInt, 123))"), null, null));
Review Comment:
Is was LTE. Hence it worked :)
Had added these to be able to test and / or. Made the tests a bit more
extensive.
All the filters actually match the record. SKIP_RECORD_KEY is being checked
for.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
