walterddr commented on code in PR #8567: URL: https://github.com/apache/pinot/pull/8567#discussion_r858097006
########## pinot-tools/src/main/java/org/apache/pinot/tools/streams/PinotRealtimeSource.java: ########## @@ -0,0 +1,191 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.tools.streams; + +import com.google.common.base.Preconditions; +import com.google.common.util.concurrent.RateLimiter; +import java.util.List; +import java.util.Properties; +import java.util.concurrent.ExecutorService; +import java.util.concurrent.Executors; +import javax.annotation.Nullable; +import org.apache.pinot.spi.stream.RowWithKey; +import org.apache.pinot.spi.stream.StreamDataProducer; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + + +/** + * Represents one Pinot Real Time Source that is capable of + * 1. Keep running forever + * 2. Pull from generator and write into StreamDataProducer + * The Source has a thread that is looping forever. + */ +public class PinotRealtimeSource implements AutoCloseable { + private static final Logger LOGGER = LoggerFactory.getLogger(PinotRealtimeSource.class); + public static final String KEY_OF_MAX_MESSAGE_PER_SECOND = "pinot.stream.max.message.per.second"; + public static final String KEY_OF_TOPIC_NAME = "pinot.topic.name"; + public static final long DEFAULT_MAX_MESSAGE_PER_SECOND = Long.MAX_VALUE; + public static final long DEFAULT_EMPTY_SOURCE_SLEEP_MS = 10; + final StreamDataProducer _producer; + final PinotSourceGenerator _generator; + final String _topicName; + final ExecutorService _executor; + final Properties _properties; + PinotStreamRateLimiter _rateLimiter; + protected volatile boolean _shutdown; + + /** + * Constructs a source by passing in a Properties file, a generator, and a producer + * @param settings the settings for all components passed in + * @param generator the generator that can create data + * @param producer the producer to write the generator's data into + */ + public PinotRealtimeSource(Properties settings, PinotSourceGenerator generator, StreamDataProducer producer) { + this(settings, generator, producer, null, null); + } + + /** + * Constructs a source by passing in properties file, a generator, a producer and an executor service + * @param settings the settings for all components passed in + * @param generator the generator that can create data + * @param producer the producer to write the generator's data into + * @param executor the preferred executor instead of creating a thread pool. Null for default one + * @param rateLimiter the specialized rate limiter for customization. Null for default guava one + */ + public PinotRealtimeSource(Properties settings, PinotSourceGenerator generator, StreamDataProducer producer, + @Nullable ExecutorService executor, @Nullable PinotStreamRateLimiter rateLimiter) { + _properties = settings; + _producer = producer; + Preconditions.checkNotNull(_producer, "Producer of a stream cannot be null"); + _generator = generator; + Preconditions.checkNotNull(_generator, "Generator of a stream cannot be null"); + _executor = executor == null ? Executors.newSingleThreadExecutor() : executor; + _topicName = settings.getProperty(KEY_OF_TOPIC_NAME); + Preconditions.checkNotNull(_topicName, "Topic name needs to be set via " + KEY_OF_TOPIC_NAME); + _rateLimiter = rateLimiter == null ? new GuavaRateLimiter(extractMaxQps(settings)) : rateLimiter; + } + + public void run() { + _executor.execute(() -> { + while (!_shutdown) { + List<RowWithKey> rows = _generator.generateRows(); + // we expect the generator implementation to return empty rows when there is no data available + // as a stream, we expect data to be available all the time + if (rows.isEmpty()) { + try { + Thread.sleep(DEFAULT_EMPTY_SOURCE_SLEEP_MS); + } catch (InterruptedException ex) { + LOGGER.warn("Interrupted from sleep, will check shutdown flag later", ex); + } + } else { + _rateLimiter.acquire(rows.size()); + if (!_shutdown) { + _producer.produceKeyedBatch(_topicName, rows); Review Comment: +1. this actually is very helpful. https://github.com/apache/pinot/issues/8537 is likely due to a batch produce instability. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
