WangCHX commented on code in PR #8498: URL: https://github.com/apache/pinot/pull/8498#discussion_r856880362
########## pinot-core/src/main/java/org/apache/pinot/core/operator/filter/H3InclusionIndexFilterOperator.java: ########## @@ -0,0 +1,160 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.core.operator.filter; + +import it.unimi.dsi.fastutil.longs.LongSet; +import java.util.Collections; +import java.util.List; +import org.apache.commons.lang3.tuple.Pair; +import org.apache.pinot.common.request.context.ExpressionContext; +import org.apache.pinot.common.request.context.ExpressionContext.Type; +import org.apache.pinot.common.request.context.predicate.EqPredicate; +import org.apache.pinot.common.request.context.predicate.Predicate; +import org.apache.pinot.core.common.Operator; +import org.apache.pinot.core.operator.blocks.FilterBlock; +import org.apache.pinot.core.operator.dociditerators.ScanBasedDocIdIterator; +import org.apache.pinot.core.operator.docidsets.BitmapDocIdSet; +import org.apache.pinot.segment.local.utils.GeometrySerializer; +import org.apache.pinot.segment.local.utils.H3Utils; +import org.apache.pinot.segment.spi.IndexSegment; +import org.apache.pinot.segment.spi.index.reader.H3IndexReader; +import org.apache.pinot.spi.exception.BadQueryRequestException; +import org.apache.pinot.spi.utils.BytesUtils; +import org.locationtech.jts.geom.Geometry; +import org.roaringbitmap.buffer.BufferFastAggregation; +import org.roaringbitmap.buffer.ImmutableRoaringBitmap; +import org.roaringbitmap.buffer.MutableRoaringBitmap; + + +/** + * A filter operator that uses H3 index for geospatial data inclusion + */ +public class H3InclusionIndexFilterOperator extends BaseFilterOperator { + + private static final String EXPLAIN_NAME = "INCLUSION_FILTER_H3_INDEX"; + + private static final String OPERATOR_NAME = "H3InclusionIndexFilterOperator"; + + private final IndexSegment _segment; + private final Predicate _predicate; + private final int _numDocs; + private final H3IndexReader _h3IndexReader; + private final LongSet _fullyCoverH3Cells; + private final LongSet _potentialCoverH3Cells; + private final boolean _isPositiveCheck; + + public H3InclusionIndexFilterOperator(IndexSegment segment, Predicate predicate, int numDocs) { + _segment = segment; + _predicate = predicate; + _numDocs = numDocs; + + List<ExpressionContext> arguments = predicate.getLhs().getFunction().getArguments(); + Geometry geometry; + // Assume first argument is Literal, and second argument is IDENTIFIER for St_Contains. + assert arguments.get(1).getType() == Type.IDENTIFIER; Review Comment: sure. remove the assumption. and also checked in FilterPlanNode: ``` if (functionName.equals("st_within") || functionName.equals("stwithin")) { if (arguments.get(0).getType() == ExpressionContext.Type.IDENTIFIER && arguments.get(1).getType() == ExpressionContext.Type.LITERAL) { String columnName = arguments.get(0).getIdentifier(); return columnName != null && _indexSegment.getDataSource(columnName).getH3Index() != null; } return false; } else { if (arguments.get(1).getType() == ExpressionContext.Type.IDENTIFIER && arguments.get(0).getType() == ExpressionContext.Type.LITERAL) { String columnName = arguments.get(1).getIdentifier(); return columnName != null && _indexSegment.getDataSource(columnName).getH3Index() != null; } return false; } ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
