Jackie-Jiang commented on code in PR #8574:
URL: https://github.com/apache/pinot/pull/8574#discussion_r856457431
##########
pinot-controller/src/main/java/org/apache/pinot/controller/BaseControllerStarter.java:
##########
@@ -493,7 +493,7 @@ protected void configure() {
private ServiceStatus.ServiceStatusCallback
generateServiceStatusCallback(HelixManager helixManager) {
return new ServiceStatus.ServiceStatusCallback() {
- private boolean _isStarted = false;
+ private volatile boolean _isStarted = false;
Review Comment:
Good catch. `_statusDescription` might also need to be `volatile`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
