jackjlli commented on code in PR #8483:
URL: https://github.com/apache/pinot/pull/8483#discussion_r854735768
##########
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotInstanceAssignmentRestletResource.java:
##########
@@ -191,6 +190,22 @@ public Map<InstancePartitionsType, InstancePartitions>
assignInstances(
return instancePartitionsMap;
}
+ /**
+ * Assign instances given the type of instancePartitions.
+ * @param instancePartitionsMap the empty map to be filled.
+ * @param tableConfig table config
+ * @param instanceConfigs list of instance configs
+ * @param instancePartitionsType type of instancePartitions
+ */
+ private void assignInstancesForInstancePartitionsType(
+ Map<InstancePartitionsType, InstancePartitions> instancePartitionsMap,
TableConfig tableConfig,
+ List<InstanceConfig> instanceConfigs, InstancePartitionsType
instancePartitionsType) {
+ InstancePartitions existingInstancePartitions = InstancePartitionsUtils
+
.fetchOrComputeInstancePartitions(_resourceManager.getHelixZkManager(),
tableConfig, instancePartitionsType);
Review Comment:
Updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
