PrachiKhobragade commented on code in PR #8550:
URL: https://github.com/apache/pinot/pull/8550#discussion_r853460563
##########
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java:
##########
@@ -2133,10 +2139,11 @@ static void validateRequest(BrokerRequest
brokerRequest, int queryResponseLimit)
* <ul>
* <li>Value for 'LIMIT' <= configured value</li>
* <li>Query options must be set to SQL mode</li>
+ * <li>Check if numReplicaGroups option provided is valid</li>
* </ul>
*/
@VisibleForTesting
- static void validateRequest(PinotQuery pinotQuery, int queryResponseLimit) {
+ static void validateRequest(PinotQuery pinotQuery, int queryResponseLimit,
int numReplicas) {
Review Comment:
This is being removed from validateRequest, validation will be in
instanceSelector
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
