xiangfu0 commented on code in PR #8557:
URL: https://github.com/apache/pinot/pull/8557#discussion_r853315366
##########
pinot-common/src/main/java/org/apache/pinot/sql/parsers/CalciteSqlParser.java:
##########
@@ -107,6 +108,40 @@ private static String removeTerminatingSemicolon(String
sql) {
return sql;
}
+ public static SqlNodeAndOptions compileToSqlNodeAndOptions(String sql)
+ throws Exception {
+ // Remove the comments from the query
+ sql = removeComments(sql);
+
+ // Remove the terminating semicolon from the query
+ sql = removeTerminatingSemicolon(sql);
+
+ // Extract OPTION statements from sql as Calcite Parser doesn't parse it.
+ List<String> options = extractOptionsFromSql(sql);
Review Comment:
Yeah, since we already have the OPTIONS handler and be able to parse it out,
then I don't complain.
Eventually, this should all go to Parser.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
