[GitHub] [pinot] xiangfu0 commented on a diff in pull request #8554: Ensure all records are pushed in Pulsar Consumer Test

[GitBox]

xiangfu0 commented on code in PR #8554:
URL: https://github.com/apache/pinot/pull/8554#discussion_r851847552


##########
pinot-plugins/pinot-stream-ingestion/pinot-pulsar/src/test/java/org/apache/pinot/plugin/stream/pulsar/PulsarConsumerTest.java:
##########
@@ -273,16 +336,35 @@ public void testPartitionLevelConsumerBatchMessages()
     }
   }
 
-  public MessageId getMessageIdForPartitionAndIndex(int partitionNum, int 
index) {
+  private MessageId getMessageIdForPartitionAndIndex(int partitionNum, int 
index) {
     MessageId startMessageIdRaw = 
_partitionToFirstMessageIdMap.get(partitionNum);
     MessageIdImpl startMessageId = 
MessageIdImpl.convertToMessageIdImpl(startMessageIdRaw);
     return DefaultImplementation.newMessageId(startMessageId.getLedgerId(), 
index, partitionNum);
   }
 
-  public MessageId getBatchMessageIdForPartitionAndIndex(int partitionNum, int 
index) {
+  private MessageId getBatchMessageIdForPartitionAndIndex(int partitionNum, 
int index) {
     MessageId startMessageIdRaw = 
_partitionToFirstMessageIdMapBatch.get(partitionNum);
     BatchMessageIdImpl startMessageId = (BatchMessageIdImpl) 
MessageIdImpl.convertToMessageIdImpl(startMessageIdRaw);
     return new BatchMessageIdImpl(startMessageId.getLedgerId(), index / 
BATCH_SIZE, partitionNum, index % BATCH_SIZE,
         startMessageId.getBatchSize(), startMessageId.getAcker());
   }
+
+  private void waitForCondition(Function<Void, Boolean> condition, long 
checkIntervalMs, long timeoutMs,

Review Comment:
   remove this?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org