richardstartin commented on code in PR #8491: URL: https://github.com/apache/pinot/pull/8491#discussion_r849785673
########## pinot-broker/src/main/java/org/apache/pinot/broker/failuredetector/FailureDetectorFactory.java: ########## @@ -0,0 +1,56 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.broker.failuredetector; + +import org.apache.commons.lang.StringUtils; +import org.apache.pinot.common.metrics.BrokerMetrics; +import org.apache.pinot.spi.env.PinotConfiguration; +import org.apache.pinot.spi.utils.CommonConstants.Broker; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + + +public class FailureDetectorFactory { + private FailureDetectorFactory() { + } + + private static final Logger LOGGER = LoggerFactory.getLogger(FailureDetectorFactory.class); + + public static FailureDetector getFailureDetector(PinotConfiguration config, BrokerMetrics brokerMetrics) { + String className = config.getProperty(Broker.FailureDetector.CONFIG_OF_CLASS_NAME); + if (StringUtils.isEmpty(className)) { + LOGGER.info("Class name is not configured, falling back to NoOpFailureDetector"); + return new NoOpFailureDetector(); + } else { + LOGGER.info("Initializing failure detector with class: {}", className); + try { + FailureDetector failureDetector = + (FailureDetector) Class.forName(className).getDeclaredConstructor().newInstance(); Review Comment: The point is exposing the class name at all prevents from changing the class name, which isn’t good. If you have a separate configuration setting and map that to the class you want to use, without exposing the class name, you can refactor if you want. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
