richardstartin commented on code in PR #8535:
URL: https://github.com/apache/pinot/pull/8535#discussion_r849740777
##########
pinot-common/src/main/java/org/apache/pinot/common/function/scalar/DataTypeConversionFunctions.java:
##########
@@ -32,6 +33,23 @@ public class DataTypeConversionFunctions {
private DataTypeConversionFunctions() {
}
+ @ScalarFunction
+ public static Object cast(Object value, String targetType) {
+ if (value == null) {
+ return null;
+ }
+ try {
+ Class<?> clazz = value.getClass();
+ boolean isMultiValue = clazz.isArray();
+ PinotDataType sourceType = isMultiValue
+ ? PinotDataType.getMultiValueType(clazz)
+ : PinotDataType.getSingleValueType(clazz);
+ return PinotDataType.valueOf(targetType.toUpperCase()).convert(value,
sourceType);
Review Comment:
I've done something similar. Please take another look. It needs to be a
little more complicated than blindly delegating to PinotDataType in every case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
