Jackie-Jiang commented on code in PR #8485:
URL: https://github.com/apache/pinot/pull/8485#discussion_r848959813
##########
pinot-core/src/main/java/org/apache/pinot/core/operator/filter/JsonMatchFilterOperator.java:
##########
@@ -87,4 +94,20 @@ public String toExplainString() {
stringBuilder.append(",predicate:").append(_predicate.toString());
return stringBuilder.append(')').toString();
}
+
+ private void record(ImmutableRoaringBitmap bitmap) {
+ InvocationRecording recording = Tracing.activeRecording();
+ if (recording.isEnabled()) {
+ recording.setColumnName(_predicate.getLhs().getIdentifier());
+ recording.setFilter(FilterType.INDEX, describeJsonPredicate());
+ recording.setNumDocsMatchingAfterFilter(bitmap.getCardinality());
+ }
+ }
+
+ private String describeJsonPredicate() {
Review Comment:
I see what I was missing before. You added multiple traces for the json
predicate, one for each sub-predicate under the json expression.
To get the detailed info, we have to go into the index reader then. We can
probably add that separately if needed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
