walterddr commented on PR #8484: URL: https://github.com/apache/pinot/pull/8484#issuecomment-1095758884
> High level question: Do we introduce this custom parser to accelerate the parsing but keep the same preserved words as `BABEL`? the goal is not accelerate parsing but to get precise control on our SQL syntax - BABEL enabled lots of unnecessary non-reserved keyword that may or may not be intended (and so far we only tested 10~20ish such reserved keyword usages). yes, we copied the whole list for backward compatibility but ideally speaking we should only kept the list of non-reserved keywords that we support in `CalciteSqlCompilerTest.java` > Can we get the same performance if switching to `DEFAULT`? I feel it might not worth the maintenance overhead if it is just for some extra preserved words. Switching to DEFAULT or MYSQL_5 standard is the goal (see my TODO comment), but we still need to customized the list of non-reserved keyword + maintain backward compatibility until we can warn users that certain reserved keywords will be removed in the future (if we decided to do so) > If it is a must have in order to support more custom query syntax support, then go for it yes. for supporting custom syntax. It is required. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
