Jackie-Jiang commented on code in PR #8508:
URL: https://github.com/apache/pinot/pull/8508#discussion_r847787254
##########
pinot-core/src/main/java/org/apache/pinot/core/common/MinionConstants.java:
##########
@@ -101,6 +101,11 @@ public static abstract class MergeTask {
public static final String SEGMENT_NAME_PREFIX_KEY = "segmentNamePrefix";
public static final String SEGMENT_NAME_POSTFIX_KEY = "segmentNamePostfix";
public static final String FIXED_SEGMENT_NAME_KEY = "fixedSegmentName";
+
+ // This field is set in segment metadata custom map to indicate if the
segment is safe to be merged.
+ // Tasks can take use of this field to coordinate with the merge task. By
default, segment is safe
+ // to merge, so existing segments w/o this field can be merged just as
before.
+ public static final String SEGMENT_ZK_METADATA_SHOULD_NOT_MERGE =
"shouldNotMerge";
Review Comment:
For consistency
```suggestion
public static final String SEGMENT_ZK_METADATA_SHOULD_NOT_MERGE_KEY =
"shouldNotMerge";
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
