jasperjiaguo commented on code in PR #8036: URL: https://github.com/apache/pinot/pull/8036#discussion_r847636575
########## compatibility-verifier/sample-test-suite/post-server-rollback.yaml: ########## @@ -44,3 +58,14 @@ operations: description: Run query on FeatureTest2 using SQL queryFileName: queries/feature-test-2-sql-realtime.queries expectedResultsFileName: query-results/feature-test-2-sql-realtime.results + - type: queryOp + description: Run query on FeatureTest3 using SQL + queryFileName: queries/feature-test-3-sql-realtime.queries + expectedResultsFileName: query-results/feature-test-3-sql-realtime.results + shouldCompareNumEntriesScannedInFilter: true + shouldCompareNumConsumingSegmentsQueried: true Review Comment: Removed, as we discussed offline, these comparisons should fire automatically if these fields exit in metadata of query results. Also removed the corresponding fields in existing query comparisons as we don't check them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org