Jackie-Jiang commented on code in PR #8343:
URL: https://github.com/apache/pinot/pull/8343#discussion_r846547501
##########
pinot-common/src/main/java/org/apache/pinot/common/config/provider/TableCache.java:
##########
@@ -242,6 +252,23 @@ private void putTableConfig(ZNRecord znRecord)
_tableNameMap.put(tableNameWithType.toLowerCase(), tableNameWithType);
_tableNameMap.put(rawTableName.toLowerCase(), rawTableName);
}
+ addOverrideHintsColumns(tableConfig, schemaName, _caseInsensitive);
+ }
+
+ private void addOverrideHintsColumns(TableConfig tableConfig, String
schemaName, boolean caseInsensitive) {
Review Comment:
This can cause problems when the schema is shared by multiple table configs
(e.g. hybrid table), and they have different index configured. We should avoid
making dependencies between table config and schema. If this is for the column
name check, we can probably skip the check for timestamp index column if
explicitly called
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
