Jackie-Jiang commented on PR #8118: URL: https://github.com/apache/pinot/pull/8118#issuecomment-1093481291
> > Sorry I missed track of this PR. Checked the code and it should be safe to add the support without performance regression. @kbastani Could you please address the comments and we can move forward. > > We might also want to use thread local and `DateTimeFormat` for better performance. cc @richardstartin for more inputs > > As I mentioned before, two exceptions have already been thrown before this codepath is hit. As I'm sure everyone is aware, throwing exception which fill in their stack traces is extremely expensive. So performance is a moot point by the time this code executes. Sure, let's keep it simple then -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
