siddharthteotia commented on code in PR #8457: URL: https://github.com/apache/pinot/pull/8457#discussion_r844571286
########## pinot-spi/src/main/java/org/apache/pinot/spi/trace/InvocationRecording.java: ########## @@ -0,0 +1,113 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.spi.trace; + +import org.apache.pinot.spi.data.FieldSpec; + + +public interface InvocationRecording { Review Comment: (nit) brief javadocs please Also, IIUC the granularity of this is at each operator level ? In that case, may be we should call it OperatorInvocationRecording ? ########## pinot-spi/src/main/java/org/apache/pinot/spi/trace/InvocationRecording.java: ########## @@ -0,0 +1,113 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.spi.trace; + +import org.apache.pinot.spi.data.FieldSpec; + + +public interface InvocationRecording { + + /** + * Sets the number of docs scanned by the operator. + * @param docsScanned how many docs were scanned. + */ + default void setDocsScanned(int docsScanned) { + } + + /** + * Sets the number of documents matching after a filter has been applied. + * Indicates whether the index was selective or not. + * @param numDocsMatchingAfterFilter how many docs still match after applying the filter + */ + default void setNumDocsMatchingAfterFilter(int numDocsMatchingAfterFilter) { Review Comment: Bit confused between this and previous function. The current `numDocsScanned` metric that we measure and return actually represents the selectivity of the query. If `numDocsMatchingAfterFilter` (which I feel is a very intuitive name) represents selectivity, then what do the `docsScanned` in the previous function represent ? I guess totalDocs ? Fair to say that `docsScanned` and `numDocsMatchingAfterFilter` will be same if no filter ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
