[GitHub] [pinot] nizarhejazi commented on a diff in pull request #8468: Support Single-valued BigDecimal columns across different SQL statements, and Pinot transforms and operators

[GitBox]

nizarhejazi commented on code in PR #8468:
URL: https://github.com/apache/pinot/pull/8468#discussion_r844303267


##########
pinot-core/src/main/java/org/apache/pinot/core/common/BlockValSet.java:
##########
@@ -84,6 +85,13 @@
    */
   double[] getDoubleValuesSV();
 
+  /**
+   * Returns the BigDecimal[] values for a single-valued column.
+   *
+   * @return Array of BigDecimal[] values
+   */
+  BigDecimal[] getBigDecimalValuesSV();

Review Comment:
   @Jackie-Jiang Added it for convenience to avoid calling two APIs: 
`getBytesValuesSV` and `ArrayCopyUtils.copy`.
   
   I will address and move the logic to IdentifierTransformFunction.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org