ddcprg commented on code in PR #7358:
URL: https://github.com/apache/pinot/pull/7358#discussion_r843736058
##########
pinot-plugins/pinot-input-format/pinot-avro-base/src/main/java/org/apache/pinot/plugin/inputformat/avro/AvroRecordExtractor.java:
##########
@@ -31,22 +34,22 @@
import org.apache.pinot.spi.data.readers.GenericRow;
import org.apache.pinot.spi.data.readers.RecordExtractorConfig;
-
-/**
- * Extractor for Avro Records
- */
+/** Extractor for Avro Records */
public class AvroRecordExtractor extends BaseRecordExtractor<GenericRecord> {
private Set<String> _fields;
private boolean _extractAll = false;
+ private boolean _applyLogicalTypes = false;
Review Comment:
this setting should come from table config in order to avoid potentially
break existing ingestion that come with logical types, however
`RecordExtractorConfig` is always null. Is anyone working on this logic at the
moment? I could give that a go as I'll need to add the setting for this feature
##########
pinot-plugins/pinot-input-format/pinot-avro-base/src/main/java/org/apache/pinot/plugin/inputformat/avro/AvroRecordExtractor.java:
##########
@@ -31,22 +34,22 @@
import org.apache.pinot.spi.data.readers.GenericRow;
import org.apache.pinot.spi.data.readers.RecordExtractorConfig;
-
-/**
- * Extractor for Avro Records
- */
+/** Extractor for Avro Records */
public class AvroRecordExtractor extends BaseRecordExtractor<GenericRecord> {
private Set<String> _fields;
private boolean _extractAll = false;
+ private boolean _applyLogicalTypes = false;
Review Comment:
this setting should come from table config in order to avoid potentially
breaking existing ingestion that come with logical types, however
`RecordExtractorConfig` is always null. Is anyone working on this logic at the
moment? I could give that a go as I'll need to add the setting for this feature
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
