Jackie-Jiang commented on code in PR #8398: URL: https://github.com/apache/pinot/pull/8398#discussion_r843364644
########## pinot-spi/src/main/java/org/apache/pinot/spi/config/table/IndexingConfig.java: ########## @@ -53,6 +53,8 @@ private SegmentPartitionConfig _segmentPartitionConfig; private boolean _aggregateMetrics; private boolean _nullHandlingEnabled; + private boolean _optimizeDictionaryEnabled; + private double _thresholdMinPercentDictionaryStorageSaved; Review Comment: @KKcorps Understood. What I meant is that let's keep the absolute ratio instead of the saved ratio because in certain cases we might want to generate raw index even if the size is slightly larger, and configuring negative saved ratio can be confusing. To keep the same behavior, we may make the default 0.85 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
