npawar commented on code in PR #8017:
URL: https://github.com/apache/pinot/pull/8017#discussion_r843356090
##########
pinot-plugins/pinot-stream-ingestion/pinot-pulsar/src/main/java/org/apache/pinot/plugin/stream/pulsar/PulsarConfig.java:
##########
@@ -54,14 +54,12 @@ public PulsarConfig(StreamConfig streamConfig, String
subscriberId) {
if (offsetCriteria.isSmallest()) {
Review Comment:
optional: you could use the PulsarUtils method here. Would need another one
for subscriptionInitialPositionToMesasgeId, but would help move all this util
logic to one place
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
